[Spice-devel] [PATCH spice-server 1/2] sound: Use default message handler if possible

[Jonathon Jongsma]

Acked-by: Jonathon Jongsma <jjongsma at redhat.com>


On Thu, 2017-02-02 at 16:29 +0000, Frediano Ziglio wrote:
> red_channel_client_handle_message can handle base messages
> so reuse it.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/sound.c | 16 +---------------
>  1 file changed, 1 insertion(+), 15 deletions(-)
> 
> diff --git a/server/sound.c b/server/sound.c
> index 4548c25..7c36174 100644
> --- a/server/sound.c
> +++ b/server/sound.c
> @@ -320,18 +320,6 @@ static int
> snd_record_handle_write(RecordChannelClient *record_client, size_t si
>  }
>  
>  static int
> -playback_channel_handle_parsed(RedChannelClient *rcc, uint32_t size,
> uint16_t type, void *message)
> -{
> -    switch (type) {
> -    case SPICE_MSGC_DISCONNECTING:
> -        break;
> -    default:
> -        return red_channel_client_handle_message(rcc, size, type,
> message);
> -    }
> -    return TRUE;
> -}
> -
> -static int
>  record_channel_handle_parsed(RedChannelClient *rcc, uint32_t size,
> uint16_t type, void *message)
>  {
>      RecordChannelClient *record_client = RECORD_CHANNEL_CLIENT(rcc);
> @@ -368,8 +356,6 @@ record_channel_handle_parsed(RedChannelClient
> *rcc, uint32_t size, uint16_t type
>          record_client->start_time = mark->time;
>          break;
>      }
> -    case SPICE_MSGC_DISCONNECTING:
> -        break;
>      default:
>          return red_channel_client_handle_message(rcc, size, type,
> message);
>      }
> @@ -1427,7 +1413,7 @@
> playback_channel_class_init(PlaybackChannelClass *klass)
>      object_class->constructed = playback_channel_constructed;
>  
>      channel_class->parser =
> spice_get_client_channel_parser(SPICE_CHANNEL_PLAYBACK, NULL);
> -    channel_class->handle_parsed = playback_channel_handle_parsed;
> +    channel_class->handle_parsed =
> red_channel_client_handle_message;
>      channel_class->send_item = playback_channel_send_item;
>  }
>