[Spice-devel] [PATCH 1/5] Shadow: remove unused 'owner' field

Frediano Ziglio fziglio at redhat.com
Mon Feb 6 10:17:13 UTC 2017


> 
> This field is set but is never read. The only usage of this field was
> removed in 3dffeb25edc9d7a893d9697fc7b19739aff36cc9

Acked-by: Frediano Ziglio <fziglio at redhat.com>

> ---
>  server/tree.c | 1 -
>  server/tree.h | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/server/tree.c b/server/tree.c
> index 58f6c5c..ea11000 100644
> --- a/server/tree.c
> +++ b/server/tree.c
> @@ -196,7 +196,6 @@ Shadow* shadow_new(DrawItem *item, const SpicePoint
> *delta)
>  
>      shadow->base.type = TREE_ITEM_TYPE_SHADOW;
>      shadow->base.container = NULL;
> -    shadow->owner = item;
>      region_clone(&shadow->base.rgn, &item->base.rgn);
>      region_offset(&shadow->base.rgn, delta->x, delta->y);
>      ring_item_init(&shadow->base.siblings_link);
> diff --git a/server/tree.h b/server/tree.h
> index 648725c..35b78ab 100644
> --- a/server/tree.h
> +++ b/server/tree.h
> @@ -50,7 +50,6 @@ struct TreeItem {
>  struct Shadow {
>      TreeItem base;
>      QRegion on_hold;
> -    DrawItem* owner;
>  };
>  
>  #define IS_SHADOW(item) ((item)->type == TREE_ITEM_TYPE_SHADOW)

Frediano


More information about the Spice-devel mailing list