[Spice-devel] [virt-viewer] Show errors generated by connection dialog

Christophe de Dinechin cdupontd at redhat.com
Wed Feb 8 16:25:25 UTC 2017


When running 'remote-viewer' without arguments,
and selecting a non-supported protocol, e.g. ssh://foo,
the generated error was silently swallowed by the retry loop.
This was introduced in 06b2c382468876a19600374bd59475e66d488af8.
---
 src/remote-viewer.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/remote-viewer.c b/src/remote-viewer.c
index 13c6e7c..c9ef4bb 100644
--- a/src/remote-viewer.c
+++ b/src/remote-viewer.c
@@ -1196,6 +1196,9 @@ cleanup:
     type = NULL;
 
     if (!ret && priv->open_recent_dialog) {
+        if (error) {
+            virt_viewer_app_simple_message_dialog(&self->parent, "%s", error->message);
+        }
         g_clear_error(&error);
         goto retry_dialog;
     }
-- 
2.9.3




More information about the Spice-devel mailing list