[Spice-devel] [spice-gtk v6 5/9] spicy: keep status of mouse/agent on server mode

[Victor Toso]

Hi,

On Wed, Feb 08, 2017 at 06:55:14PM +0100, Christophe de Dinechin wrote:
>
> > On 31 Jan 2017, at 12:08, Victor Toso <victortoso at redhat.com> wrote:
> >
> > +#define SPICY_UNGRAB_INFO "Use %s to ungrab mouse”
>
> Shouldn’t that be
>
> #define SPICY_UNGRAB_INFO	 _(“Use %s to ungrab mouse”)

Maybe? I'd argue that spicy is a testing tool and keeping it in english
is fine. But i see some (wrong) paths at po folder:

po/ChangeLog:3: * Added initial french translation for spicy and snappy.
po/fr.po:21:#: ../gtk/spicy.c:129
po/fr.po:25:#: ../gtk/spicy.c:130
po/fr.po:29:#: ../gtk/spicy.c:131
po/fr.po:34:#: ../gtk/spicy.c:140
po/fr.po:38:#: ../gtk/spicy.c:196
po/fr.po:43:#: ../gtk/spicy.c:198
po/fr.po:48:#: ../gtk/spicy.c:257 ../gtk/spicy.c:683
po/fr.po:52:#: ../gtk/spicy.c:257 ../gtk/spicy.c:683
po/fr.po:56:#: ../gtk/spicy.c:265
po/fr.po:64:#: ../gtk/spicy.c:360
po/fr.po:68:#: ../gtk/spicy.c:366
po/fr.po:72:#: ../gtk/spicy.c:374
po/fr.po:76:#: ../gtk/spicy.c:380
po/fr.po:80:#: ../gtk/spicy.c:388
po/fr.po:84:#: ../gtk/spicy.c:395
po/fr.po:88:#: ../gtk/spicy.c:403
po/fr.po:92:#: ../gtk/spicy.c:411
po/fr.po:96:#: ../gtk/spicy.c:415
po/fr.po:100:#: ../gtk/spicy.c:419
po/fr.po:104:#: ../gtk/spicy.c:423
po/fr.po:108:#: ../gtk/spicy.c:485
po/fr.po:113:#: ../gtk/spicy.c:542
po/fr.po:118:#: ../gtk/spicy.c:639
po/fr.po:122:#: ../gtk/spicy.c:640
po/fr.po:126:#: ../gtk/spicy.c:694
po/fr.po:130:#: ../gtk/spicy.c:696
po/fr.po:134:#: ../gtk/spicy.c:698
po/fr.po:138:#: ../gtk/spicy.c:831
po/fr.po:142:#: ../gtk/spicy.c:849
po/fr.po:146:#: ../gtk/spicy.c:854 ../gtk/snappy.c:144

Aha, are you using it in French? :)

> > +        g_string_append_printf(status, "\t"SPICY_UNGRAB_INFO, seq);
>
> Just curious, why do you split the \t from the rest of the message?

Well, I don't really have good rationale on why I did it :)
I wanted the string in one place (#define) and the "\t" sort of belongs
to the format it'll be presented. (not that this is good/correct)

Cheers,
        toso

>
>
> Christophe
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170209/9a418ded/attachment.sig>