[Spice-devel] [PATCH v6 4/5] vdagentd: early return on bad message size

[Christophe Fergeau]

On Fri, Feb 10, 2017 at 04:54:50PM +0100, Michal Suchánek wrote:
> Of course, if you split the commit and bisection points to one of the
> commits that clearly change the behavior for a few message types it is
> then easy to check handling of those messages and fix it. If the
> bisection points to the supposedly noop commit you will still have to
> check everything.

Yes, but you know the commit is supposed to be a noop, so your goal is
to figure out why it's not a noop, rather than checking everything,
figuring out which parts of the change are just code movements, which
parts of the change are improvements done at the same time as the code
movements (this means searching for the rationale for each improvement,
which is mentioned in the commit log), and which part of the change is
buggy. Much harder than just checking for a noop in my opinion.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170210/2ba4f103/attachment.sig>