[Spice-devel] [PATCH spice-gtk] keymaps.csv: Add missing columns

Daniel P. Berrange berrange at redhat.com
Tue Feb 14 13:47:06 UTC 2017


On Tue, Feb 14, 2017 at 08:33:09AM -0500, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
> > > 
> > > Allow easier processing by scripts and csv editors
> > > ---
> > > Also it renders nicely on github
> > >  https://github.com/xerus/spice-gtk/blob/keymap/src/keymaps.csv
> > > From that ^ table is obvious which values are missing
> > 
> > With
> > 
> >   git diff HEAD^ --word-diff --word-diff-regex='[^[:space:]]'
> > 
> > you can easily see that there's no difference beside the added
> > columns at the end and with a
> > 
> >   perl -pe 's.[^,\n]..sg' src/keymaps.csv | uniq
> > 
> > you can see all rows have the same amount of columns
> > 
> > Acked-by: Frediano Ziglio <fziglio at redhat.com>
> 
> Are we still in sync with gtk-vnc? https://git.gnome.org/browse/gtk-vnc/tree/src/keymaps.csv
> 
> An option would be to have a submodule for keymaps and related code,
> to be shared with gtk-vnc, spice-gtk, eventually qemu (and a freerdp
> gtk widget etc)

I had done some work in this respect, but I don't think I ever pushed
it anywhere. Originally I had been intending to put it on freedesktop
but their admins never responded to repo creation requests. gitlab
would be a better choice these days. Lemme try and find my previous
work...


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|


More information about the Spice-devel mailing list