[Spice-devel] [PATCH spice-server 2/4] Do not set not blocking flag twice

Christophe Fergeau cfergeau at redhat.com
Tue Feb 14 15:25:30 UTC 2017


On Tue, Feb 14, 2017 at 10:16:43AM -0500, Frediano Ziglio wrote:
> > 
> > On Mon, Feb 13, 2017 at 11:03:17AM +0000, Frediano Ziglio wrote:
> > > Non blocking flag is set for all connection inside reds.c so
> > > there's no need to set again for the single client channel.
> > > 
> > > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > 
> > I'd move that code in a RedsStream helper while at it, I can send a
> > patch if you want.
> > 
> > Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> > 
> > Christophe
> > 
> 
> Agreed. Better by the way in a follow up, this just remove lines
> but do not change where the setting is done.

Yup, agreed, hence the ACK here, and the proposal to send a patch ;)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170214/10403e9e/attachment.sig>


More information about the Spice-devel mailing list