[Spice-devel] [vdagent-linux v8 3/4] Adjust size checks

[Victor Toso]

On Wed, Feb 15, 2017 at 10:48:06AM +0100, Victor Toso wrote:
> From: Christophe Fergeau <cfergeau at redhat.com>

'vdagentd:' prefix here too?

Just a small note, this was also wrong before "vdagentd: early
return on bad message size" patch.

Acked-by: Victor Toso <victortoso at redhat.com>

>
> ---
>  src/vdagentd/vdagentd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c
> index 8d43700..2329489 100644
> --- a/src/vdagentd/vdagentd.c
> +++ b/src/vdagentd/vdagentd.c
> @@ -395,8 +395,6 @@ static gboolean vdagent_message_check_size(const VDAgentMessage *message_header)
>      case VD_AGENT_FILE_XFER_DATA:
>      case VD_AGENT_CLIPBOARD:
>      case VD_AGENT_CLIPBOARD_GRAB:
> -    case VD_AGENT_CLIPBOARD_REQUEST:
> -    case VD_AGENT_CLIPBOARD_RELEASE:
>      case VD_AGENT_AUDIO_VOLUME_SYNC:
>      case VD_AGENT_ANNOUNCE_CAPABILITIES:
>          if (message_header->size < min_size) {
> @@ -409,6 +407,8 @@ static gboolean vdagent_message_check_size(const VDAgentMessage *message_header)
>      case VD_AGENT_FILE_XFER_STATUS:
>      case VD_AGENT_DISPLAY_CONFIG:
>      case VD_AGENT_REPLY:
> +    case VD_AGENT_CLIPBOARD_REQUEST:
> +    case VD_AGENT_CLIPBOARD_RELEASE:
>      case VD_AGENT_MAX_CLIPBOARD:
>      case VD_AGENT_CLIENT_DISCONNECTED:
>          if (message_header->size != min_size) {
> -- 
> 2.9.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170215/5689bcea/attachment.sig>