[Spice-devel] [PATCH spice-server 2/4] Do not set TCP_NODELAY flag twice

[Christophe Fergeau]

On Wed, Feb 15, 2017 at 06:48:32AM -0500, Frediano Ziglio wrote:
> > 
> > On Wed, Feb 15, 2017 at 11:31:59AM +0000, Frediano Ziglio wrote:
> > > TCP_NODELAY flag is set by default for all connection inside
> > > reds.c so there's no need to set again for the single
> > > client channel.
> > 
> > Would have been nice to keep "Do not set not blocking flag twice"
> > together with this patch, and push them at the same time..
> > 
> > > 
> > > Note that there are still some call to setsockopt to set this
> > > option but in this case the flag can reset the flag.
> > 
> > 'some calls'
> > the flag can reset the flag?
> > 
> 
> Yes, confusing, what about:
> 
> "Note that there are still some call to setsockopt to change this
> option."

"some calls", and yes, much clearer :)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170215/e8fc9d7b/attachment.sig>