[Spice-devel] [PATCH spice-server 1/3] Use class name in comment

Frediano Ziglio fziglio at redhat.com
Wed Feb 15 16:46:21 UTC 2017


> 
> ACK, maybe rcc: in the short log
> 

I'd use red-channel-client: as consistent with the second...
or change both to rcc!

Not strong opinions, on the logs there are both versions

Frediano

> On Wed, Feb 15, 2017 at 12:49:05PM +0000, Frediano Ziglio wrote:
> > red_channel seems a variable name.
> > 
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  server/red-channel-client.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/server/red-channel-client.h b/server/red-channel-client.h
> > index 4f1d481..75d6cc3 100644
> > --- a/server/red-channel-client.h
> > +++ b/server/red-channel-client.h
> > @@ -205,7 +205,7 @@ typedef enum
> >      SPICE_SERVER_ERROR_FAILED
> >  } SpiceServerError;
> >  
> > -/* Messages handled by red_channel
> > +/* Messages handled by RedChannel
> >   * SET_ACK - sent to client on channel connection
> >   * Note that the numbers don't have to correspond to spice message types,
> >   * but we keep the 100 first allocated for base channel approach.



More information about the Spice-devel mailing list