[Spice-devel] [PATCH spice-server 2/3] red-channel-client: Remove unused vfuncs

Christophe Fergeau cfergeau at redhat.com
Wed Feb 15 16:50:26 UTC 2017


On Wed, Feb 15, 2017 at 11:44:53AM -0500, Frediano Ziglio wrote:
> > 
> > On Wed, Feb 15, 2017 at 12:49:06PM +0000, Frediano Ziglio wrote:
> > > RedChannelClient is responsible for talking to the client so it knows
> > > how if is connected or not.
> > 
> > s/how//
> > 
> > I'd mention explicitly that it's RedChannelClient::is_connected and
> > RedChannelClient::disconnect which are dropped (would even belong in the
> > shortlog if it's not too long).
> > 
> 
> What about
> 
> "red-channel-client: Remove unused RedChannelClient::{is_connected,disconnect}"

Works for me! (s/red-channel-client/rcc to keep the shortlog short)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170215/87b1e3e3/attachment.sig>


More information about the Spice-devel mailing list