[Spice-devel] [PATCH spice-gtk v4 6/6] usb-device-widget: Migrate to GtkContainer from GtkBox

[Christophe Fergeau]

On Tue, Feb 14, 2017 at 07:05:18PM +0100, Pavel Grunt wrote:
> GtkVBox is deprecated since Gtk 3.2, GtkBox is going to be
> deprecated. Just use the GtkContainer api.
> ---
> Per the commit bc3d12efb20423d5b1ebd490658f687c4bd323fd the class is considered final,
> so this shouldn't be an ABI break
> 
> If we consider it as the ABI break we can just use the GtkContainer api

Oh, if the SpiceUsbDeviceWidget structure is not exposed in public
headers, it's definitely not an ABI break. The only think I can think of
which would cause a difference in behaviour is if some code is
directly using SpiceUsbDeviceWidget as a GtkBox, but hopefully this is
not done?

I'd Acked-by: Christophe Fergeau <cfergeau at redhat.com> this

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170216/0750e73b/attachment.sig>