[Spice-devel] [PATCH spice-gtk v5 0/6] Avoid usage of deprecated functions

Pavel Grunt pgrunt at redhat.com
Fri Feb 17 10:24:49 UTC 2017


Hi,

this is a follow up to Francois's patches which avoided some deprecated
warnings in the SpiceDisplay widget. (Also it seems that the client behavior
under Wayland is better (reported by Christophe), there are still some issues
with server mouse mode - https://bugzilla.redhat.com/show_bug.cgi?id=1285378#c15 )

The main difference is the usage of GdkSeat api that was introduced in Gtk 3.20.

Getting rid of deprecated symbols is neccessary to be able to compile
with the gtk master.

Thanks,
Pavel

rpms are available at: https://copr.fedorainfracloud.org/coprs/pgrunt/spice-gtk-deprecated/

v5:
 - Fixed the broken usb widget (Christophe)
 - updated commit messages (Christophe)
 - helper function should not use the gdk namespace (Christophe)

v4:
 - changes per the review by Victor
 - usb-device-widget internally changed to GtkContainer - see also the commit
   bc3d12efb20423d5b1ebd490658f687c4bd323fd

v3:
 - changed to use gdk_cursor_new_from_name which should work under wayland (Christophe)
 - replaced deprecated GtkVBox by GtkBox

v2 (Frediano's review):
 - removed usage of deprecated function (gdk_display_warp_pointer, gdk_window_get_pointer)
 - kept G_GNUC_BEGIN_IGNORE_DEPRECATIONS guards to avoid warning with gtk < 3.20

Pavel Grunt (6):
  gtk: Use gdk_cursor_new_from_name
  gtk: Use gdk_window_get_device_position
  gtk: Use gdk_device_warp
  gtk: Avoid deprecated gdk_keyboard_grab
  gtk: Avoid deprecated gdk_pointer_grab
  usb-device-widget: Migrate to GtkGrid from GtkBox

 src/spice-widget.c      | 138 ++++++++++++++++++++++++++++++++++++------------
 src/usb-device-widget.c |  25 +++++----
 2 files changed, 119 insertions(+), 44 deletions(-)

-- 
2.11.1



More information about the Spice-devel mailing list