[Spice-devel] [PATCH spice-server] Fix minor inconsistencies with declaration and definition

Jonathon Jongsma jjongsma at redhat.com
Fri Feb 17 16:05:01 UTC 2017


A good example of where using bool would help us ;)

Acked-by: Jonathon Jongsma <jjongsma at redhat.com>


On Thu, 2017-02-16 at 10:08 +0000, Frediano Ziglio wrote:
> Declaration used gboolean while definition used int.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/agent-msg-filter.c   | 2 +-
>  server/red-channel-client.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/server/agent-msg-filter.c b/server/agent-msg-filter.c
> index 17f8e88..da6640c 100644
> --- a/server/agent-msg-filter.c
> +++ b/server/agent-msg-filter.c
> @@ -38,7 +38,7 @@ void agent_msg_filter_config(AgentMsgFilter
> *filter,
>  void agent_msg_filter_init(AgentMsgFilter *filter,
>                             gboolean copy_paste, gboolean file_xfer,
>                             gboolean use_client_monitors_config,
> -                           int discard_all)
> +                           gboolean discard_all)
>  {
>      memset(filter, 0, sizeof(*filter));
>      agent_msg_filter_config(filter, copy_paste, file_xfer,
> diff --git a/server/red-channel-client.c b/server/red-channel-
> client.c
> index a0e213f..b583da2 100644
> --- a/server/red-channel-client.c
> +++ b/server/red-channel-client.c
> @@ -1789,7 +1789,7 @@ void
> red_channel_client_disconnect(RedChannelClient *rcc)
>      red_channel_on_disconnect(channel, rcc);
>  }
>  
> -int red_channel_client_is_blocked(RedChannelClient *rcc)
> +gboolean red_channel_client_is_blocked(RedChannelClient *rcc)
>  {
>      return rcc && rcc->priv->send_data.blocked;
>  }


More information about the Spice-devel mailing list