[Spice-devel] [spice-gtk v1 7/7] gtk-session: move variables to internal scope
Pavel Grunt
pgrunt at redhat.com
Thu Feb 23 13:26:09 UTC 2017
On Wed, 2017-02-22 at 14:11 +0100, Victor Toso wrote:
> From: Victor Toso <me at victortoso.com>
>
> Signed-off-by: Victor Toso <victortoso at redhat.com>
> ---
> src/spice-gtk-session.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session.c
> index cd546d3..595b327 100644
> --- a/src/spice-gtk-session.c
> +++ b/src/spice-gtk-session.c
> @@ -613,8 +613,7 @@ static void clipboard_get_targets(GtkClipboard
> *clipboard,
>
> SpiceGtkSessionPrivate *s = self->priv;
> guint32 types[SPICE_N_ELEMENTS(atom2agent)] = { 0 };
> - char *name;
> - int a, m, t;
> + int a;
> int selection;
> gint num_types;
>
> @@ -632,7 +631,9 @@ static void clipboard_get_targets(GtkClipboard
> *clipboard,
> /* Set all Atoms that matches our current protocol
> implementation */
> num_types = 0;
> for (a = 0; a < n_atoms; a++) {
> - name = gdk_atom_name(atoms[a]);
> + gint m, t;
t is used only in the 'm' for cycle - considering previous patches
Also would be nice to change them to unsigned (they are compared with
an unsigned value)
Pavel
> + gchar *name = gdk_atom_name(atoms[a]);
> +
> for (m = 0; m < SPICE_N_ELEMENTS(atom2agent); m++) {
> if (strcasecmp(name, atom2agent[m].xatom) != 0) {
> continue;
More information about the Spice-devel
mailing list