[Spice-devel] [spice v9] Preferred video codec message (27 Feb)
Victor Toso
victortoso at redhat.com
Mon Feb 27 09:35:55 UTC 2017
From: Victor Toso <me at victortoso.com>
Hi,
Finally a new version with rework from previous iteration.
To test it easily, I'm using this branch [0] that introduces a streaming
information in spicy tool (no streaming it sets to None, with vp8 stream
it sets it to "vp8", and so on)
[0] https://gitlab.com/victortoso/spice-gtk/commits/spicy-tools-label
changes between v8->v9:
* Server might drop the message with newer clients (Pavel)
- If a new client has a video-codec that server might not know, we were
dropping the message. Now we are just ignoring it.
* Handling duplicated cases (Frediano)
- Instead of doing a check on the size of the array, we check if given
video-codec has been included already.
* Fix the sort (Christophe de Dinechin)
- Although the order of video-codec was alright it could be the case
that we could change the encoder order. This is somewhat a minor
corner case as the only situation we can have this is with
spice:mjpeg and gstreamer:mjpeg
* Use spice_debug instead of spice_info (Frediano)
* Fixed a few typos (Frediano)
* Code style! Always use brackets (Frediano)
* Use g_array_sized_new() where it fits (Christophe de Dinechin)
* Use g_array_append_vals() where it fits (Christophe de Dinechin)
Victor Toso (1):
dcc: handle preferred video codec message
server/dcc-private.h | 5 ++
server/dcc.c | 132 +++++++++++++++++++++++++++++++++++++++++++++++
server/dcc.h | 1 +
server/display-channel.c | 2 +
server/stream.c | 3 +-
5 files changed, 141 insertions(+), 2 deletions(-)
--
2.9.3
More information about the Spice-devel
mailing list