[Spice-devel] [PATCH] Remove X == TRUE tests for non-boolean values

[Frediano Ziglio]

> 
> Using X == TRUE is fragile, since the input value is a uint8_t. It would be
> surprising if the value was set to 2 or 0xFF and the test failed.
> 
> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>

Acked-by: Frediano Ziglio <fziglio at redhat.com>

> ---
>  server/dcc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/server/dcc.c b/server/dcc.c
> index afe37b1..7cfa72b 100644
> --- a/server/dcc.c
> +++ b/server/dcc.c
> @@ -398,7 +398,7 @@ static void
> add_drawable_surface_images(DisplayChannelClient *dcc, Drawable *dra
>  
>          surface_id = drawable->surface_deps[x];
>          if (surface_id != -1) {
> -            if (dcc->priv->surface_client_created[surface_id] == TRUE) {
> +            if (dcc->priv->surface_client_created[surface_id]) {
>                  continue;
>              }
>              dcc_create_surface(dcc, surface_id);
> @@ -407,7 +407,7 @@ static void
> add_drawable_surface_images(DisplayChannelClient *dcc, Drawable *dra
>          }
>      }
>  
> -    if (dcc->priv->surface_client_created[drawable->surface_id] == TRUE) {
> +    if (dcc->priv->surface_client_created[drawable->surface_id]) {
>          return;
>      }
>  

Frediano