[Spice-devel] [PATCH spice-server] style: Specify boolean style convention

[Christophe Fergeau]

On Mon, Feb 27, 2017 at 07:04:30AM -0500, Frediano Ziglio wrote:
> > 
> > On Mon, Feb 27, 2017 at 06:36:18AM -0500, Frediano Ziglio wrote:
> > > What about:
> > > 
> > > "style: Change boolean style convention
> > > 
> > > Was agreed to use C99 syntax for boolean.
> > > New code should attempt to follow the new style."
> > 
> > "Following
> > https://lists.freedesktop.org/archives/spice-devel/2017-February/035800.html
> > , the consensus was to use 'bool' rather than 'gboolean', and to use
> > true/false rather than TRUE/FALSE. New code should attempt to follow the
> > new style."
> > 
> > Christophe
> > 
> 
> "and to use true/false rather than TRUE/FALSE." is maybe misleading.
> Few places where it's another type should stay consistent with the type
> (unless I didn't understand).

Imo it's fine not to be 100% accurate in the commit log, the actual
change has all the details.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170227/d67d70c6/attachment.sig>