[Spice-devel] [PATCH spice-server] sound: Avoid unused IOV_MAX definition

[Frediano Ziglio]

Ping

----- Original Message -----
> From: "Frediano Ziglio" <fziglio at redhat.com>
> To: "Pavel Grunt" <pgrunt at redhat.com>
> Cc: spice-devel at lists.freedesktop.org
> Sent: Wednesday, February 15, 2017 1:23:35 PM
> Subject: Re: [Spice-devel] [PATCH spice-server] sound: Avoid unused IOV_MAX definition
> 
> > 
> > Hi,
> > 
> > On Wed, 2017-02-15 at 12:37 +0000, Frediano Ziglio wrote:
> > > The usage was removed with commit
> > > 7ea1f2c133a8e57523078ba3112cec6a1d2f353e
> > > ("sound: Use RedChannelClient to receive/send data").
> > > 
> > > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > > ---
> > >  server/sound.c | 4 ----
> > >  1 file changed, 4 deletions(-)
> > > 
> > > diff --git a/server/sound.c b/server/sound.c
> > > index 530a7ec..afe9c96 100644
> > > --- a/server/sound.c
> > > +++ b/server/sound.c
> > > @@ -39,10 +39,6 @@
> > >  #include "sound.h"
> > >  #include "main-channel-client.h"
> > >  
> > > -#ifndef IOV_MAX
> > > -#define IOV_MAX 1024
> > > -#endif
> > > -
> > 
> > Actually it was "redefined" - its definition is in red-channel-
> > client.h which is included through main-channel-client.h.
> > 
> 
> Can't be redefined, it's using a #ifndef.
> But it's not used in this source file so there is no
> need to have it defined. Was used with DummyChannel
> (DummyChannel == Voldemort!).
> 
> > There is also some usage in reds-stream.c (I am not sure if it
> > includes the header) besides that it can be private to red-channel-
> > client.c
> > 
> > Pavel
> > 
> 
> I sent already a patch doing this.
> I think reds-stream.c use it as a flag to limit iovcnt.
> Note that reds-stream.c do not include red-channel-client.h.
> 
> > >  #define SND_RECEIVE_BUF_SIZE     (16 * 1024 * 2)
> > >  #define RECORD_SAMPLES_SIZE (SND_RECEIVE_BUF_SIZE >> 2)
> > >  
> > 
>