[Spice-devel] [spice v1] syntax-check: Fix missing AUTHORS

Daniel P. Berrange berrange at redhat.com
Tue Feb 28 13:44:42 UTC 2017


On Tue, Feb 28, 2017 at 02:37:25PM +0100, Victor Toso wrote:
> From: Victor Toso <me at victortoso.com>
> 
> Signed-off-by: Victor Toso <victortoso at redhat.com>
> ---
>  AUTHORS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/AUTHORS b/AUTHORS
> index 2b0fe24..99f6c18 100644
> --- a/AUTHORS
> +++ b/AUTHORS
> @@ -28,6 +28,7 @@ Patches also contributed by
>      소병철 <byungchul.so at samsung.com>
>      Cédric Bosdonnat <cbosdonnat at suse.com>
>      Christian Ruppert <idl0r at qasl.de>
> +    Christophe de Dinechin <dinechin at redhat.com>
>      Cole Robinson <crobinso at redhat.com>
>      Daniel P. Berrange <berrange at redhat.com>
>      Dan Kenigsberg <danken at redhat.com>

FWIW, git can trivially auto-fill an AUTHORS file at make dist time.
Libvirt does it as follows:

Rename AUTHORS to AUTHORS.in, replace the names beneath the
"Patches also contributed by" line, with "#authorslist#" then
add to Makefile.am

dist-hook: gen-AUTHORS

.PHONY: gen-AUTHORS
gen-AUTHORS:
        $(AM_V_GEN)if test -d $(srcdir)/.git; then \
            out="`cd $(srcdir) && git log --pretty=format:'%aN <%aE>' | sort -u`" && \
            perl -p -e "s/#authorslist#// and print '$$out'" \
              < $(srcdir)/AUTHORS.in > $(distdir)/AUTHORS-tmp && \
            mv -f $(distdir)/AUTHORS-tmp $(distdir)/AUTHORS ; \
        fi

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|


More information about the Spice-devel mailing list