[Spice-devel] [PATCH v10 01/11] sound: Convert SndChannelClient to GObject

[Christophe Fergeau]

On Fri, Jan 06, 2017 at 04:30:33AM -0500, Frediano Ziglio wrote:
> I think the main problem reviewing this patch is that people keeps
> thinking that this big patch is the results of many small changes.
> As explained is not so the patch is big and it's better to consider
> the overall code before and after instead of the patch itself.

We don't assume that there were incremental changes that were all merged
together. I understand all these changes more or less all happened at
the same time and in a random order. However, after getting something
that works and looks good, it's not unusual to get back one step, and
see if there is an incremental set of changes which would make sense
(and this after getting to the end goal, it's usually easier than doing
that before starting the changes), and which would give an easy to
review patch series rather than a big patch doing many things.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170109/25a7be7f/attachment.sig>