[Spice-devel] [spice-server 04/17] sound: Remove duplicate AudioFrame typedef

Frediano Ziglio fziglio at redhat.com
Wed Jan 11 10:58:55 UTC 2017


> 
> It's already defined before in the same source file.
> 
> Based on a patch from Frediano Ziglio <fziglio at redhat.com>
> 
> Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> ---
>  server/sound.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/server/sound.c b/server/sound.c
> index 1f6c243..d24a0d9 100644
> --- a/server/sound.c
> +++ b/server/sound.c
> @@ -123,7 +123,6 @@ struct SndChannelClient {
>      snd_channel_cleanup_channel_proc cleanup;
>  };
>  
> -typedef struct AudioFrame AudioFrame;
>  struct AudioFrame {
>      uint32_t time;
>      uint32_t samples[SND_CODEC_MAX_FRAME_SIZE];

Can I ack my hunk or should I consider your signed-off like
an ack? I usually prefer a sign A + sign B + ack A

Frediano


More information about the Spice-devel mailing list