[Spice-devel] [spice-server 02/17] sound: Remove dummy-channel.[ch]

[Christophe Fergeau]

On Wed, Jan 11, 2017 at 05:57:15AM -0500, Frediano Ziglio wrote:
> > 
> > This is no longer used since "sound: Convert SndChannel to GObject"
> > 
> > Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> 
> Didn't notice could be already removed.
> However this looks like a partial patch I had in my list, some credit
> is missing.

Yes and no, I know you had a similar patch queued, but it's trivial
enough that I'm not sure I went further than reading its shortlog before
adding that patch, so I could argue this is an independant
reimplementation of the same patch you had ;)

With that said, I'm fine with adding whatever crediting you want (I
assume the same "Based on a patch from Frediano" line as in the other
patches?).

> Also the other part of this initial patch ended up merged in your
> "sound: Convert SndChannelClient to RedChannelClient" patch,
> perhaps for coherence would be better to split also the other patch

The patch removing dummy-channel.[ch] cannot be squashed anywhere as the
commit where it could have been squashed has already been pushed.

I think it's more logical to have the patch removing
dummy-channel-client.[ch] to be in the commit removing usage of
DummyChannelClient, especially as it's now smaller.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170111/91602cd9/attachment.sig>