[Spice-devel] [PATCH 3/3] Update ifdefs for gstreamer availability

Christophe Fergeau cfergeau at redhat.com
Mon Jan 16 10:10:13 UTC 2017


On Sun, Jan 15, 2017 at 06:12:22PM +0200, Snir Sheriber wrote:
> Using ifdefs with the recently defined conditional for having
> gstreamer_0_10 or gstreamer_1_0
> ---
>  server/Makefile.am                 | 8 +-------
>  server/reds.c                      | 4 ++--
>  server/tests/test-codecs-parsing.c | 4 ++--
>  server/video-encoder.h             | 2 +-
>  4 files changed, 6 insertions(+), 12 deletions(-)

I think I'd merge this with the 1st patch.
After this patch, there are no more occurrences of HAVE_GSTREAMER_xxx in
any Makefile.am file, so you could remove the corresponding
AM_CONDITIONAL from configure.ac, and only keep the one for
HAVE_GSTREAMER.

The HAVE_GSTREAMER_xxx #defines (used in C files) come from
spice-common/m4/spice-deps.m4.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170116/d724e84d/attachment.sig>


More information about the Spice-devel mailing list