[Spice-devel] [spice-common] ssl: Use ASN1_STRING_get0_data instead of ASN1_STRING_data

Christophe Fergeau cfergeau at redhat.com
Thu Jan 19 16:05:03 UTC 2017


On Tue, Jan 17, 2017 at 03:19:00PM +0100, Victor Toso wrote:
> Hi,
> 
> On Fri, Jan 13, 2017 at 12:12:50PM +0100, Christophe Fergeau wrote:
> > From: Sebastian Andrzej Siewior <sebastian at breakpoint.cc>
> >
> > The latter is deprecated, so might be removed at  some point in the
> > future. This also adds a compatibility wrapper for OpenSSL < 1.1.0.
> >
> > Signed-off-by: Sebastian Andrzej Siewior <sebastian at breakpoint.cc>
> > ---
> >  common/ssl_verify.c | 20 ++++++++++++++------
> >  1 file changed, 14 insertions(+), 6 deletions(-)
> >
> > diff --git a/common/ssl_verify.c b/common/ssl_verify.c
> > index 601252e..b6a96a7 100644
> > --- a/common/ssl_verify.c
> > +++ b/common/ssl_verify.c
> > @@ -33,6 +33,14 @@
> >  #include <string.h>
> >  #include <gio/gio.h>
> >
> 
> I would include a FIXME here, to require >= 1.1.0 in the future, just
> make it easier to track this.

I can add one, but I haven't done so in the spice-gtk patch. I expect
openssl 1.0 support to stay there for quite some time fwiw (I'd bet that
this code will be replaced by 'something else' before we decide we can
drop openssl 1.0 support ;)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170119/e25662f9/attachment.sig>


More information about the Spice-devel mailing list