[Spice-devel] [NSIS] Install virtio-rng driver

Yedidyah Bar David didi at redhat.com
Mon Jan 23 08:30:14 UTC 2017


On Sun, Jan 22, 2017 at 5:22 PM, Uri Lublin <uril at redhat.com> wrote:
> On 01/22/2017 04:07 PM, Yedidyah Bar David wrote:
>>
>> Bug-Url: https://bugzilla.redhat.com/1398560
>> Change-Id: Ic7bad17fd01dc3d2d9c6a4f530eff724c4ea9403
>> Signed-off-by: Yedidyah Bar David <didi at redhat.com>
>> ---
>>  win-guest-tools.nsis | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis
>> index 1951721..9a90444 100644
>> --- a/win-guest-tools.nsis
>> +++ b/win-guest-tools.nsis
>> @@ -188,6 +188,21 @@ Section "install"
>>    Push "PCI\VEN_1AF4&DEV_1000&SUBSYS_00011AF4&REV_00"
>>    Call InstallDriver
>>
>> +  # Install rng driver
>> +  ${If}  ${IsWinVista}
>> +  ${OrIf} ${IsWin2008}
>> +  ${OrIf} ${IsWin7}
>> +  ${OrIf} ${IsWin2008R2}
>> +  ${OrIf} ${IsWin8}
>> +  ${OrIf} ${IsWin2012}
>> +  ${OrIf} ${IsWin8.1}
>> +  ${OrIf} ${IsWin2012R2}
>> +    Push "viorng"
>> +    Push "viorng"
>> +    Push "PCI\VEN_1AF4&DEV_1002"
>
>
> Hi,
>
> 1. I think device ID should be 1005 (see /usr/share/hwdata/pci.ids)

I think you are right. No idea how I got the wrong one.

> 2. There are a long white-list compared to other drivers with no list
>    at all. Why do you need it ? Only for WinXP ? or maybe just because
>    it's a bit safer ?

I checked the driver directories and listed the OSes for which I found
drivers. A similar check was done for vioscsi. I now see that Christophe
changed that in a recent patch "Add Windows 10 support", will update that
to be the same as there.

> 3. Do you have to bump virtio-win version or the scripts automatically
>    download the latest virtio available ?

It's automatic, but I'll rebase anyway on Christophe's other patch
"Update to latest virtio-win/vdagent releases" which does this
explicitly.

>
> Thanks,
>     Uri.
>
>
>> +    Call InstallDriver
>> +  ${EndIf}
>> +
>>  !ifdef OVIRT
>>    Call InstallOVirtAgentService
>>  !endif
>>
>



-- 
Didi


More information about the Spice-devel mailing list