[Spice-devel] [PATCH spice-gtk v3 6/6] usb-device-widget: Do not use GtkVBox

Victor Toso victortoso at redhat.com
Mon Jan 23 13:54:25 UTC 2017


Hi,

On Fri, Jan 20, 2017 at 04:53:53PM +0100, Pavel Grunt wrote:
> ---
>  src/usb-device-widget.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/usb-device-widget.c b/src/usb-device-widget.c
> index b394499..747887c 100644
> --- a/src/usb-device-widget.c
> +++ b/src/usb-device-widget.c
> @@ -40,14 +40,14 @@
>  
>  struct _SpiceUsbDeviceWidget
>  {
> -    GtkVBox parent;
> +    GtkBox parent;
>  
>      SpiceUsbDeviceWidgetPrivate *priv;
>  };
>  
>  struct _SpiceUsbDeviceWidgetClass
>  {
> -    GtkVBoxClass parent_class;
> +    GtkBoxClass parent_class;


"gtk_vbox_new has been deprecated since version 3.2 and should not be
 used in newly-written code.
 You can use gtk_box_new() with GTK_ORIENTATION_VERTICAL instead, which
 is a quick and easy change. But the recommendation is to switch to
 GtkGrid, since GtkBox is going to go away eventually. See Migrating
 from other containers to GtkGrid."

So, GtkGrid in the future.
Acked-by: Victor Toso <victortoso at redhat.com>

>  
>      /* signals */
>      void (*connect_failed) (SpiceUsbDeviceWidget *widget,
> -- 
> 2.11.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170123/5b41f60a/attachment.sig>


More information about the Spice-devel mailing list