[Spice-devel] [PATCH v5 3/5] gstreamer: Add gst_format to the table of supported formats

[Christophe Fergeau]

On Sat, Jan 21, 2017 at 04:30:02AM -0500, Frediano Ziglio wrote:
> > 
> > On Tue, Jan 10, 2017 at 02:20:39PM +0000, Frediano Ziglio wrote:
> > > This format is required to add metadata.
> > > These metadata can be used to pass different strides or additional
> > > information to pass dma buffers.
> > 
> > I don't really understand what you want to do with that additional info
> > from the commit log :(
> > "Add metadata" ? how does adding another constant help with that ?
> > 
> 
> Maybe
> 
>   This format is required to add metadata using gst_buffer_add_video_meta_full.

"to add metadata to the source buffer using ..." ?

>   These metadata can be used to pass different strides or additional
>   information to pass dma buffers.

"This metadata.." (I think ?)
"to pass strides/offsets, or dmabuf-specific information"

But yeah, much clearer this way, thanks :)

> 
> > 
> > > 
> > > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > > ---
> > >  server/gstreamer-encoder.c | 12 +++++++-----
> > >  1 file changed, 7 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
> > > index 4a0917e..ba81377 100644
> > > --- a/server/gstreamer-encoder.c
> > > +++ b/server/gstreamer-encoder.c
> > > @@ -26,6 +26,7 @@
> > >  #include <gst/gst.h>
> > >  #include <gst/app/gstappsrc.h>
> > >  #include <gst/app/gstappsink.h>
> > > +#include <gst/video/video.h>
> > >  
> > >  #include "red-common.h"
> > >  #include "video-encoder.h"
> > > @@ -42,6 +43,7 @@
> > >  typedef struct {
> > >      SpiceBitmapFmt spice_format;
> > >      char format[8];
> > > +    GstVideoFormat gst_format;
> > 
> > If we add this here, it seems most of the following members would be
> > redundant and can be filled using gst_video_format_get_info() ?
> > 
> > Christophe
> > 
> 
> This structure handle both Gstreamer 0.10 and 1.0, in 0.10
> there's no gst_video_format_get_info.
> I have another patch (somewhere...) to have this structure
> stripped down of unneeded fields depending on GStreamer
> version.

Yeah, only remembered long after sending my email that most of the
fields are there for GStreamer 0.10 use.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170124/ffd0e2c7/attachment.sig>