[Spice-devel] [NSIS 3/3] Install virtio-rng driver

[Yedidyah Bar David]

On Tue, Jan 24, 2017 at 11:10 AM, Christophe Fergeau
<cfergeau at redhat.com> wrote:
> On Tue, Jan 24, 2017 at 10:16:21AM +0200, Yedidyah Bar David wrote:
>> Change-Id: I4cc6dbe33d7d189d74189188ca18a46b85362237
>> Bug-Url: https://bugzilla.redhat.com/1398560
>> Signed-off-by: Yedidyah Bar David <didi at redhat.com>
>> ---
>>  win-guest-tools.nsis | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis
>> index 2092edc..8d57d85 100644
>> --- a/win-guest-tools.nsis
>> +++ b/win-guest-tools.nsis
>> @@ -181,6 +181,14 @@ Section "install"
>>    Push "PCI\VEN_1AF4&DEV_1000&SUBSYS_00011AF4&REV_00"
>>    Call InstallDriver
>>
>> +  # Install rng driver
>> +  ${If} ${AtLeastWinVista}
>> +    Push "viorng"
>> +    Push "viorng"
>> +    Push "PCI\VEN_1AF4&DEV_1005"
>
> Not directly related to this patch, but do you know if the virtio-win
> drivers support virtio 1.0? (the PCIID is becomes DEV_1044 in this
> situation). If they do support it, we'll probably need to adapt
> installation of all virtio drivers.

No idea, adding Cole.

>
> Acked-by: Christophe Fergeau <cfergeau at redhat.com>

Added.

Also acked your patches, pushed, and merged in both oVirt gerrit and
gitlab. Thanks for the reviews!

Now going to branch it in oVirt to build 4.1. Will also push/post
a patch to bump master to 4.2.

Best,
-- 
Didi