[Spice-devel] [spice-server v2 00/10] Convert SndChannelClient to GObject

Christophe Fergeau cfergeau at redhat.com
Tue Jan 24 11:52:35 UTC 2017


Hey,

This series is an attempt at splitting "sound: Convert SndChannelClient to GObject"
https://lists.freedesktop.org/archives/spice-devel/2017-January/034773.html
in much smaller chunks to ease reviews, and make git history more usable.
This might be a bit artificial at times (especially the conversion to GObject
before converting to RedChannelClient), but in my opinion most of the patches
make sense on their own.
The series should build and audio should still be functional with each of these
patches, though I've only tested playback, not recording.

A few patches would need slightly better logs, Frediano, it would be nice if
you could help with that.

Since the previous version, I've moved "sound: Prefer snd_set_command()  over
snd_*_send_*() " after the conversion to sending data using RedChannelClient,
I've added error handling to the calls to snd_channel_config_socket().

Christophe

Christophe Fergeau (10):
  sound: Rework spice_server_playback_get_buffer() error handling
  sound: Implement snd_channel_config_socket
  sound: Add sanity checks in snd_{playback,record}_send
  sound: Remove SndChannelClient::send_data::marshaller
  sound: Remove SndChannelClient::channel
  sound: Remove code from spice_server_record_get_samples()
  sound: Use RedChannelClient to receive/send data
  sound: Prefer snd_set_command() over snd_*_send_*()
  sound: Turn {Playback,Record}ChannelClient into GObjects
  sound: Convert SndChannelClient to RedChannelClient

 server/Makefile.am            |   2 -
 server/dummy-channel-client.c | 138 ------
 server/dummy-channel-client.h |  64 ---
 server/sound.c                | 963 ++++++++++++++++++------------------------
 4 files changed, 422 insertions(+), 745 deletions(-)
 delete mode 100644 server/dummy-channel-client.c
 delete mode 100644 server/dummy-channel-client.h

-- 
2.9.3



More information about the Spice-devel mailing list