[Spice-devel] [spice-server v3 06/10] sound: Remove code from spice_server_record_get_samples()

[Frediano Ziglio]

> 
> The removed code was trying to read data when
> spice_server_record_get_samples() is called. Since reading of data is
> event-driven anyway (see snd_event), it's redundant to try
> again to read more data.
> This commit removes this code as this will some refactoring easier in
> the next commits.
> 
> Based on a patch from Frediano Ziglio <fziglio at redhat.com>
> 
> Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> ---
>  server/sound.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/server/sound.c b/server/sound.c
> index ac69bfd..f27a53d 100644
> --- a/server/sound.c
> +++ b/server/sound.c
> @@ -1474,15 +1474,6 @@ SPICE_GNUC_VISIBLE uint32_t
> spice_server_record_get_samples(SpiceRecordInstance
>  
>      len = MIN(record_client->write_pos - record_client->read_pos, bufsize);
>  
> -    if (len < bufsize) {
> -        SndChannel *channel =
> SND_CHANNEL(red_channel_client_get_channel(client->channel_client));
> -        snd_receive(client);
> -        if (!channel->connection) {
> -            return 0;
> -        }
> -        len = MIN(record_client->write_pos - record_client->read_pos,
> bufsize);
> -    }
> -
>      read_pos = record_client->read_pos % RECORD_SAMPLES_SIZE;
>      record_client->read_pos += len;
>      now = MIN(len, RECORD_SAMPLES_SIZE - read_pos);

Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano