[Spice-devel] [client v3 05/10] audio: Remove spice_audio_new() from the public header

[Marc-André Lureau]

Hi

On Tue, Nov 1, 2016 at 1:20 PM Pavel Grunt <pgrunt at redhat.com> wrote:

> On Mon, 2016-10-31 at 17:15 +0100, Victor Toso wrote:
> > Hi,
> >
> > On Thu, Oct 27, 2016 at 04:07:15PM -0500, Jonathon Jongsma wrote:
> > > Seems OK to me. Looks like it was deprecated in Feb 2012.  Anybody
> > > else
> > > have objections?
> >
> > None. I also think it is safe to remove it now.
> > Pushed all the acked patches.
> >
>
> there should be a follow up to keep spice_audio_new in the map-file
> and spice-glib-sym-file on `make -C src update-symbol-files`
>

That, and update of documentation..
Imho it's not very beneficial to remove it from public header (break API),
and keep the symbol. But if we remove it from exported symbols, we break
ABI.

I would rather keep it for now, until we bump spice-gtk for API/ABI break.
No rush to do that either.

I'll send a revert patch.
-- 
Marc-André Lureau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170127/648928e1/attachment-0001.html>