[Spice-devel] [spice-server v3 10/10] sound: Convert SndChannelClient to RedChannelClient

[Frediano Ziglio]

> 
> Fwiw, see the merged patch attached to this mail. Frediano feels
> strongly that these should be merged, so I'll most likely go with this
> version.
> 
> Christophe
> 

I noted this weird hunk (that don't apply on top of previous series
without last 2 patches):

@@ -645,9 +575,9 @@ static void snd_send(SndChannelClient * client)
 {
     RedChannelClient *rcc;

-    g_return_if_fail(client != NULL);
+    g_return_if_fail(RED_IS_CHANNEL_CLIENT(client));

-    rcc = client->channel_client;
+    rcc = RED_CHANNEL_CLIENT(client);
     if (!red_channel_client_pipe_is_empty(rcc) || !client->command) {
         return;
     }


I think would be better:

     RedChannelClient *rcc;

     rcc = RED_CHANNEL_CLIENT(client);
     if (!rcc || !red_channel_client_pipe_is_empty(rcc) || !client->command) {
         return;
     }

no reason to check for type twice, RED_CHANNEL_CLIENT handle NULL cases with
warning if needed.

Or just remove the check at all...

Frediano

> On Thu, Jan 26, 2017 at 11:41:26AM -0600, Jonathon Jongsma wrote:
> > On Thu, 2017-01-26 at 07:39 -0500, Frediano Ziglio wrote:
> > > > 
> > > > SndChannelClient is now inheriting from GObject, and has switched
> > > > from using its own code for sending data to using RedChannelClient.
> > > > This commit makes it directly inherit from RedChannelClient rather
> > > > than
> > > > having a channel_client field. This allows to get rid of the whole
> > > > DummyChannel/DummyChannelClient code.
> > > > 
> > > > Based on a patch from Frediano Ziglio <fziglio at redhat.com>
> > > > 
> > > > Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> > > > ---
> > 
> > [snip]
> > 
> > > 
> > > Still think this should be merged to 9/10.
> > > 
> > > Frediano
> > > 
> > 
> > Personally I kind of like them as separate commits. But I don't feel
> > too strongly either way.
> > 
> > Jonathon