[Spice-devel] [PATCH spice-server] Avoid to use global variable for channel IDs

[Christophe Fergeau]

On Mon, Jan 30, 2017 at 07:05:14AM -0500, Frediano Ziglio wrote:
> > 
> > > Also this function could be reused for different devices and it's
> > > possible that ID is provided externally (like QXL) so scanning the
> > > used one works even in this case.
> > > 
> > > Also these channels are created per device and giving that
> > > currently there are no hot plug they are added once at start.
> > > Even allowing hot plug people should not playing continuously
> > > adding/removing them.
> > 
> > So we can just fail when there is an overflow and keep everything simple ? :)
> > 
> 
> This don't solve the external (ie by Qemu) ID allocation.

QEMU seems fine doing the allocation by itself, if you have bigger plans
for the function you are introducing, it would probably be better to
describe them in more details in a cover letter, or to show the related
patch. There is nothing QXL-related in that patch I'm currently
commenting on.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170130/69eb83b9/attachment.sig>