[Spice-devel] [spice-common 2/2] quic: Use upper-case for 'evol' constant name

Christophe Fergeau cfergeau at redhat.com
Tue Jul 4 07:18:22 UTC 2017


On Tue, Jul 04, 2017 at 01:02:39AM -0400, Frediano Ziglio wrote:
> > 
> > Constants, especially when defined using #define usually use upper-case
> > naming.
> 
> However this is not coherent with wmimax and wmiext.
> Maybe changing all?

That would mean changing the various arrays of constants too
(tabrand_chaos, bppmask, ..)


> Another way to define compile time constant in C is using
> enum but then you'll have a warning with switches.
> Are you using -O0 ?

Ah indeed, this is only triggered with -O0.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170704/0257ed99/attachment.sig>


More information about the Spice-devel mailing list