[Spice-devel] [vdagent-win PATCH 0/7] Rewrite image support and other patches

Frediano Ziglio fziglio at redhat.com
Thu Jul 6 13:31:57 UTC 2017


CxImage is used for image conversion for clipboard support.
CxImage have currently some issue:
- library is old and unsupported;
- required an old libpng library.
Currently the MingW binary we distribute due to some
issue have PNG disabled (so no clipboard image support).
Note that currently we support (before and after this patch)
only BMP and PNG. PNG is required as the default agent format.
However Windows programs wants to have BMP (specifically DIB)
in the clipboard.
This patch remove CxImage and use directly libpng (BMP is
supported directly by Windows APIs).
Tested with various formats and the compiled agent with a
Linux client.
The main concern is actually the possible problem to
support some weird/old BMP file formats.

Some additional patch fix compiling with MinGW and Mock.

The RFC patch build an executable to make easier to test
the other patches (requires some input images not included).

Frediano Ziglio (7):
  Enable debug information build on spec file
  Avoid log_level warning using a static const
  Move image handling to a separate file
  Initial rewrite of image conversion code
  Write code to decode PNG format
  Support encoding PNG images
  RFC: Add test for PNG files

 Makefile.am                 |  25 ++-
 common/vdlog.h              |   8 +-
 configure.ac                |   4 +-
 mingw-spice-vdagent.spec.in |   2 +-
 vdagent/image.cpp           | 184 ++++++++++++++++++++++
 vdagent/image.h             |  59 +++++++
 vdagent/imagepng.cpp        | 365 ++++++++++++++++++++++++++++++++++++++++++++
 vdagent/imagepng.h          |  25 +++
 vdagent/imagetest.cpp       |  78 ++++++++++
 vdagent/vdagent.cpp         |  57 +------
 10 files changed, 748 insertions(+), 59 deletions(-)
 create mode 100644 vdagent/image.cpp
 create mode 100644 vdagent/image.h
 create mode 100644 vdagent/imagepng.cpp
 create mode 100644 vdagent/imagepng.h
 create mode 100644 vdagent/imagetest.cpp

-- 
2.9.4



More information about the Spice-devel mailing list