[Spice-devel] [spice-server] build-sys: Improve portability of appending to COMMON_CFLAGS

Frediano Ziglio fziglio at redhat.com
Fri Jul 7 11:45:23 UTC 2017


> 
> This is currently done through += in configure.ac, this commit switches
> to using COMMON_CFLAGS="$COMMON_CFLAGS ..." for better portability.
> 
> Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>

Maybe for spice-server is not needed but does not hurt,

Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano

> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 9ebcfd04f..95985a68d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -139,7 +139,7 @@ dnl Check deps
>  
>  AC_CONFIG_SUBDIRS([spice-common])
>  COMMON_CFLAGS='-I ${top_srcdir}/spice-common/ -I
>  ${top_builddir}/spice-common/'
> -COMMON_CFLAGS+=' -DG_LOG_DOMAIN=\"Spice\"'
> +COMMON_CFLAGS="$COMMON_CFLAGS -DG_LOG_DOMAIN=\\\"Spice\\\""
>  AC_SUBST(COMMON_CFLAGS)
>  
>  AC_CHECK_LIBM


More information about the Spice-devel mailing list