[Spice-devel] [vdagent-win PATCH 2/7] Avoid log_level warning using a static const
Pavel Grunt
pgrunt at redhat.com
Mon Jul 10 11:29:20 UTC 2017
On Thu, 2017-07-06 at 14:31 +0100, Frediano Ziglio wrote:
> Compiler warnings for unused static variable.
> Not for constants.
>
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Pavel Grunt <pgrunt at redhat.com>
> ---
> common/vdlog.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/common/vdlog.h b/common/vdlog.h
> index 6d0413b..e645409 100644
> --- a/common/vdlog.h
> +++ b/common/vdlog.h
> @@ -41,18 +41,18 @@ private:
> FILE* _handle;
> };
>
> -enum {
> +typedef enum {
> LOG_DEBUG,
> LOG_INFO,
> LOG_WARN,
> LOG_ERROR,
> LOG_FATAL
> -};
> +} VDLogLevel;
>
> #ifdef _DEBUG
> -static unsigned int log_level = LOG_DEBUG;
> +static const VDLogLevel log_level = LOG_DEBUG;
> #else
> -static unsigned int log_level = LOG_INFO;
> +static const VDLogLevel log_level = LOG_INFO;
> #endif
>
> #define PRINT_LINE(type, format, datetime, ms, ...) \
More information about the Spice-devel
mailing list