[Spice-devel] [PATCH spice-gtk] Revert "Ignore modifiers messages if no modifiers changed"

Pavel Grunt pgrunt at redhat.com
Tue Jul 11 11:34:12 UTC 2017


This reverts commit 73cd553fb0fbd213b64d72f8b4289ed8a17fc6c0.

It may be an optimization, but it complicates turning off
the capslock once it is enabled.

https://bugs.freedesktop.org/show_bug.cgi?id=101344
---
 src/channel-inputs.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/channel-inputs.c b/src/channel-inputs.c
index f79bc38..7572bff 100644
--- a/src/channel-inputs.c
+++ b/src/channel-inputs.c
@@ -242,10 +242,8 @@ static void inputs_handle_modifiers(SpiceChannel *channel, SpiceMsgIn *in)
     SpiceInputsChannelPrivate *c = SPICE_INPUTS_CHANNEL(channel)->priv;
     SpiceMsgInputsKeyModifiers *modifiers = spice_msg_in_parsed(in);
 
-    if (c->modifiers != modifiers->modifiers) {
-        c->modifiers = modifiers->modifiers;
-        g_coroutine_signal_emit(channel, signals[SPICE_INPUTS_MODIFIERS], 0);
-    }
+    c->modifiers = modifiers->modifiers;
+    g_coroutine_signal_emit(channel, signals[SPICE_INPUTS_MODIFIERS], 0);
 }
 
 /* coroutine context */
-- 
2.13.0



More information about the Spice-devel mailing list