[Spice-devel] [PATCH spice-gtk 0/3] spice-gtk: Drop frames if they pile up because client is overloaded

Christophe de Dinechin christophe at dinechin.org
Thu Jul 13 14:57:25 UTC 2017


From: Christophe de Dinechin <dinechin at redhat.com>

This patch series is a crude attempt at getting rid of the frames backlog
when the spice client is overloaded. Another parameter I have been
playing wiht is the max-bytes parameter in the GStreamer
pipeline, which is currently set to 0 (unlimited), which is probably
a lot more than necessary.

I am still experimenting to figure out the correct values, and I am
considering less agressive heuristics than dropping *all* the
frames. I am also not entirely convinced that returning TRUE when we
clear the frames is the right thing to do. It looks like falling
through is another valid option. This is particularly true if the
frame is an I-frame.

I share this patch as is as an illustration of a scenario
where it is nice to be able to tweak parameters dynamically for
experimentation purpose. In my 'recorder' branch, the tweaks are
dynamic and defined using an environment variable.

Christophe de Dinechin (3):
  Add SPICE_TWEAK_DEFINE and SPICE_TWEAK macros
  Drop frames if the backlog is above some limit
  Add configurable value for gst_max_bytes

 src/channel-display-gst.c | 18 +++++++++++++++++-
 src/spice-util.h          |  3 +++
 2 files changed, 20 insertions(+), 1 deletion(-)

-- 
2.11.0 (Apple Git-81)



More information about the Spice-devel mailing list