[Spice-devel] [PATCH spice-gtk 2/2] build-sys: modernize gettext

[Marc-André Lureau]

----- Original Message -----
> On Thu, Jul 13, 2017 at 12:13:59PM -0400, Marc-André Lureau wrote:
> > Hi
> > 
> > ----- Original Message -----
> > > On Thu, Jul 13, 2017 at 08:58:42AM -0400, Marc-André Lureau wrote:
> > > > Hi
> > > > 
> > > > ----- Original Message -----
> > > > > On Wed, Jul 12, 2017 at 03:20:26PM +0000, Marc-André Lureau wrote:
> > > > > > >
> > > > > > > This is the latest gettext release, which is not even 1 year old,
> > > > > > > is
> > > > > > > this the only one which is going to work? Or is it possible to
> > > > > > > relax
> > > > > > > this version chekc?
> > > > > > >
> > > > > > 
> > > > > > It's quite a mess to downgrade gettext or find the minimum required
> > > > > > version. RHEL7 has 0.19.8.1 already. I suppose it should work with
> > > > > > earlier
> > > > > > 0.19 releases, perhaps even older..
> > > > > 
> > > > > RHEL7.x is using 0.18, and has been doing that for a few point
> > > > > releases.
> > > > > RHEL7.4 will apparently have gettext 0.19, but that's not released
> > > > > yet..
> > > > > Ubuntu 16.04 LTS has 0.19, Ubuntu 14.04 had 0.18. Debian
> > > > > stable/oldstable are both on 0.19.
> > > > > However, I was able to build spice-gtk git master on an up to date
> > > > > RHEL
> > > > > 7.3 after changing the required gettext version to 0.18, so I'd just
> > > > > lower the requirement.
> > > > > 
> > > > 
> > > > ACK feel free to push the change if you tested it.
> > > 
> > > Building with AM_GNU_GETTEXT_VERSION([0.18]) works, except that this
> > > triggers some autotools warnings about the use of a deprecated
> > > AM_PROG_MKDIR_P macro, which then aborts as we are using
> > > AM_INIT_AUTOMATKE([-Werror]). Did not have time to dig more into it yet.
> > > 
> > 
> > How do you reproduce it? I have no such error on f26, and my rhel7 is
> > already 0.19.8.1
> 
> git clean -dfx before running autogen.sh.
> I suspect your rhel7 is a 7.4 development version, not a released
> version.
> 

Ok thanks, make it 0.18.2 and it passes. Apparently that's what rhel/centos have, so it should work there too.

> > 
> > > I'd just revert this patch as what is meant as a build system cleanup
> > > prevents building from git on platforms which are fine otherwise.
> > 
> > They can still build from releases if they don't modify build-sys. If
> > they do, it's fair to also change gettext version, or revert this
> > patch.
> > 
> > The question is do we want/need to target those old distros for
> > developpers?
> 
> old? RHEL/CentOS 7.3 are the latest releases at the moment. You suggest
> complicating build on these distros, but for not much gain.
> 
> Christophe
>