[Spice-devel] [vdagent-win PATCH 0/7] Rewrite image support and other patches

[Uri Lublin]

On 07/14/2017 01:14 PM, Frediano Ziglio wrote:
>>
>> On 07/06/2017 04:31 PM, Frediano Ziglio wrote:
>>> CxImage is used for image conversion for clipboard support.
>>> CxImage have currently some issue:
>>> - library is old and unsupported;
>>> - required an old libpng library.
>>> Currently the MingW binary we distribute due to some
>>> issue have PNG disabled (so no clipboard image support).
>>> Note that currently we support (before and after this patch)
>>> only BMP and PNG. PNG is required as the default agent format.
>>> However Windows programs wants to have BMP (specifically DIB)
>>> in the clipboard.
>>> This patch remove CxImage and use directly libpng (BMP is
>>> supported directly by Windows APIs).
>>> Tested with various formats and the compiled agent with a
>>> Linux client.
>>> The main concern is actually the possible problem to
>>> support some weird/old BMP file formats.
>>
>>
>> Hi Frediano,
>>
>> Is it possible for png support to use the high-level api,
>> specifically png_read_png and png_write_png ?
>>
> 
> What would be the advantage?
> You still need to allocate structures and convert the image.

The advantage is simplicity.
You still need to allocate structures.
Perhaps image-conversions can be done via transforms.

Uri.