[Spice-devel] [vdagent-win PATCH v4 5/5] Add test for PNG files

[Christophe Fergeau]

On Mon, Jul 17, 2017 at 05:21:29AM -0400, Frediano Ziglio wrote:
> > 
> > Test various image and formats.
> > The idea is to decode and encode again an image and
> > check for differences. ImageMagick is used to create
> > some test image and compare results.
> > Wine is used to execute a test helper.
> > 
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> 
> A bit OT. I was trying to execute a "make check" during RPM build.
> I need some additional support, specifically wine and ImageMagick.
> ImageMagick is not a big issue, just add a BuildRequires however
> wine requires:
> - wine-core(x86-32) and wine-core(x86-64)
> - the build system to be x64
> 
> Now in some system (like RHEL 7) you cannot install wine-core(x86-32) and wine-core(x86-64)
> together so the BuildRequires will fail (works on fedora 25/26 for instance).
> 
> How to check all these in the spec file so to run in either way?

Some select bits from libvirt.spec:
%if (0%{?fedora} && 0%{?fedora} >= 23) || (0%{?rhel} && 0%{?rhel} >= 6)
    %define supported_platform 1
%else
    %define supported_platform 0
%endif

%ifnarch %{ix86} x86_64 ia64
    %define with_xen 0
    %define with_libxl 0
%endif

Any idea if the rhel7 issue you mention is likely to be fixed?

Christophe

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170717/c78c6300/attachment-0001.sig>