[Spice-devel] [vdagent-win PATCH v4 3/5] Write code to decode PNG format

[Christophe Fergeau]

On Tue, Jul 18, 2017 at 01:29:24PM -0400, Frediano Ziglio wrote:
> > On Mon, Jul 17, 2017 at 09:54:04AM +0100, Frediano Ziglio wrote:
> > > +        }
> > > +        break;
> > > +    case PNG_COLOR_TYPE_PALETTE:
> > > +        // should return 1, 2, 4 and 8, BMP does not support 2
> > 
> > Is the first '2' unwanted? Since you say later 2 is unsupported
> > 
> 
> 2 is supported by PNG but not by BMP so the line_fixup_2bpp_to_4bpp
> function.
> 
> Maybe the comment should be "should return 1, 4 and 8, BMP does not support 2" ?

Yes, I was asking about the comment, but did not manage to express this clearly ;) 

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170719/2d4d37ee/attachment-0001.sig>