[Spice-devel] [PATCH linux vdagent] Add systemd socket activation

[Christophe Fergeau]

On Wed, Jul 19, 2017 at 01:28:28PM -0500, Jonathon Jongsma wrote:
> So, Victor told me on IRC that he was having trouble getting the patch
> to work and asked me to follow up on the mailing list about how to test
>  the patch. I tested it on a Fedora25 vm as follows:
> 
> - Set up a Fedora 25 vm
> - uninstall system spice-vdagent
> - build spice-vdagent from git and install in /usr
>   $ ./configure --with-init-script=systemd --prefix=/usr
>   $ make
>   # make install
> - follow test instructions at https://bugzilla.redhat.com/show_bug.cgi?
> id=1340160
> - also test some additional scenarios such as:
>     - boot into a different runlevel (e.g. add systemd.unit=multi-
>     user.target to kernel commandline) and see whether the service is
>     running. Switch to a different target (e.g. systemctl isolate
>     graphical.target) and make sure things still work
>     - boot the vm without a vdagent channel device and then add it (e.g.
>     with virt-manager) after the guest is already running. Does the
>     agent service get started after logging into the desktop?
>     - remove the vdagent channel device from a running vm. Then add it
>     back. Does it behave as expected?
>     - anything else you can think of.
> 
> You should have the following files installed:
>   /usr/lib/systemd/system/spice-vdagentd.service
>   /usr/lib/systemd/system/spice-vdagentd.socket
> 
> It worked fine for me, but I'd definitely like to know if it doesn't
> work for others. 

I made a scratch build from a git snapshot + your patch applied, it
is available from
https://koji.fedoraproject.org/koji/taskinfo?taskID=20627487
(but I did not test it).
It's built on f26 as spice-protocol 0.12.13 is required, but should be
installable on f25 (fingers crossed ;)

It's built from the f26 .spec file, with just this change:
-%{_unitdir}/spice-vdagentd.target
+%{_unitdir}/spice-vdagentd.socket

Hope that helps,

Christophe

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170720/700a1203/attachment.sig>