[Spice-devel] [vdagent-win PATCH] RFC spec: run tests during RPM build if possible

[Frediano Ziglio]

> 
> On Thu, Jul 20, 2017 at 11:47:01AM -0400, Frediano Ziglio wrote:
> > > 
> > > On Thu, Jul 20, 2017 at 11:15:04AM +0100, Frediano Ziglio wrote:
> > > > Currently to run checks we need Wine for both 32 and 64 bit.
> > > > Some distros (like RHEL 7) don't seem to allow installing
> > > > both 32 and 64 bit versions so turn on these checks only
> > > > on recent Fedora versions.
> > > > 
> > > > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > > > ---
> > > >  mingw-spice-vdagent.spec.in | 13 +++++++++++++
> > > >  1 file changed, 13 insertions(+)
> > > > 
> > > > This patch apply on top of PNG patches.
> > > > Is there a better way to test if is possible to installe both
> > > > Wine 32 and 64? Can we say try to install both but if it can
> > > > install only one (probably x64) use only this?
> > > 
> > > You should be able to change your checks to "if we are on el7 then
> > > install only one wine version, otherwise install both". Or are you
> > > asking something different?
> > > Imo the current patch is good enough already.
> > > 
> > > Christophe
> > > 
> > 
> > Just tried. If I install only wine-core(x86-64) on el7 the line
> > 
> > %mingw_make check
> > 
> > fails trying to execute the test for 32 bit.
> 
> rpm --showrc shows that %mingw_make is
> mingw_make
> run_mingw_make()
> {
> %if 0%{?mingw_build_win32} == 1
> make -C build_win32$MINGW_BUILDDIR_SUFFIX "$@" $MINGW32_MAKE_ARGS
> %endif
> %if 0%{?mingw_build_win64} == 1
> make -C build_win64$MINGW_BUILDDIR_SUFFIX "$@" $MINGW64_MAKE_ARGS
> %endif
> }
> run_mingw_make
> 
> Dunno if changing mingw_build_win32 value around the %check would be
> enough to avoid that. Btu this is starting to get quite hackish.. :)
> I think I'd just stick with your current version.
> 
> Christophe
> 

Changing mingw_build_win32 will also disable the build if 32 bit packages.
I tried to not passing "check" and use MINGW32_MAKE_ARGS/MINGW64_MAKE_ARGS
but the result is quite terrible.
Is there a way to tell RPM (dependencies) try to install this package
(kind of optional requirement) ?

Frediano