[Spice-devel] [vdagent-win PATCH v8 4/5] Support encoding PNG images

[Christophe Fergeau]

On Wed, Jul 19, 2017 at 09:42:42AM +0100, Frediano Ziglio wrote:
> -uint8_t *PngCoder::from_bitmap(const BITMAPINFO& info, const void *bits, long &size)
> +uint8_t *PngCoder::from_bitmap(const BITMAPINFO& bmp_info, const void *bits, long &size)
>  {
> -    // TODO not implemented
> -    return NULL;
> +    // this vector is here to avoid problems as libpng use setjmp/longjmp

Nit: I'd be more specific about the problems you are avoiding, as the
goal of this comment is that someone changing this code is not going to
be careful and not introduce the issues you had in mind.

Looks good otherwise,

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170721/1dc7528b/attachment.sig>