[Spice-devel] [vdagent-win PATCH v10 1/6] Move image handling to a separate file

[Christophe Fergeau]

On Fri, Jul 21, 2017 at 02:51:36PM +0100, Frediano Ziglio wrote:
> This will make easier to change code that handle images.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> ---
>  Makefile.am         |  2 ++
>  vdagent/image.cpp   | 88 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  vdagent/image.h     | 48 +++++++++++++++++++++++++++++
>  vdagent/vdagent.cpp | 57 +++++-----------------------------
>  4 files changed, 146 insertions(+), 49 deletions(-)
>  create mode 100644 vdagent/image.cpp
>  create mode 100644 vdagent/image.h
> 
> diff --git a/Makefile.am b/Makefile.am
> index b60a718..868199e 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -42,6 +42,8 @@ vdagent_SOURCES =			\
>  	vdagent/vdagent.cpp		\
>  	vdagent/as_user.cpp		\
>  	vdagent/as_user.h		\
> +	vdagent/image.cpp		\
> +	vdagent/image.h			\
>  	$(NULL)
>  
>  vdagent_rc.$(OBJEXT): vdagent/vdagent.rc
> diff --git a/vdagent/image.cpp b/vdagent/image.cpp
> +
> +void free_raw_clipboard_image(uint8_t *data)
> +{
> +    // this is really just a free however is better to make
> +    // the free from CxImage code as on Windows the free
> +    // can be different between libraries

Forgot to mention this in the past reviews, but I don't think this
comment is needed. But this is just a minor nitpick, I'm happy to ACK
with/without it.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170724/f525509d/attachment.sig>