[Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

[Frediano Ziglio]

> 
> Hi,
> 
> On Fri, Jul 21, 2017 at 06:41:01AM -0400, Frediano Ziglio wrote:
> > >
> > > On Fri, Jul 21, 2017 at 06:18:49AM -0400, Frediano Ziglio wrote:
> > > > Beside that I wonder why I had to wait 8 months for these reviews,
> > > > not counting the time to decide to rewrite this part of code
> > > > (with all the wasted time trying to not do it) and the time we
> > > > waited to fix a known bug which is also a regression (image copy
> > > > paste are not working) and potentially a security risk (the library
> > > > versions used contain security bugs but actually the code is disabled).
> > > > Looks like that if a Red Hat client is not pushing for a fix
> > > > solutions are not that important.
> > >
> > > People can be busy with other things, and patches can fall through the
> > > cracks, it's ok to send a 'ping' message once in a while to bring a
> > > patch series  back to people's attention.
> > >
> > > Christophe
> > >
> >
> > I'm really getting tired of this reply..
> >
> > Frediano
> 
> Suggestions? Personally I would prefer if we could start using
> pull/merge requests with integrated CI to check for simple things in
> different platforms ...
> 
> I started some discussion at [0] about gitlab. Not sure if it would
> solve the problem of reviews waiting for long time but it should not
> fall through any cracks on the web interface for developers.
> 
> [0] https://lists.freedesktop.org/archives/spice-devel/2016-June/030426.html
> 
> Cheers,
>     toso
> 

Not really familiar with GitLab merge requests but on GitHub they
remain open till closed so this would help with old ones.
The big change on moving to full PR is the way of commenting patches.
Unless PR are just used for tracking and are replicated to ML but
maybe is hard to keep them consistent. I think is possible to configure
PRs to send changes to ML. This would make the history persistent on
the ML.
Could we try for a period and see how does it go?

Frediano