[Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

[Christophe Fergeau]

On Tue, Jul 25, 2017 at 01:55:11PM -0400, Frediano Ziglio wrote:
> > 
> > On Tue, Jul 25, 2017 at 07:09:22AM -0400, Frediano Ziglio wrote:
> > > > 
> > > > > >>> I see several benefits to doing this:
> > > > > >>> 
> > > > > >>> 1. We always know exactly which component and branch is being
> > > > > >>> patched
> > > > > >>> 
> > > > > > 
> > > > > > As long as contributor keep pinging or resending his series, this is
> > > > > > already the case.
> > > > > 
> > > > > As Frediano said at the beginning of the series, “I’m tired of hearing
> > > > > this
> > > > > reply”.
> > > > 
> > > > And this is not an actionable answer... My perception is that there
> > > > rarely are 'ping' on old series. Does this mean we are doing a good job
> > > > at reviews? (I doubt it or we would not have this conversation) Does
> > > > this mean patch senders do not want to do that? Why? Does this mean it's
> > > > done a lot, but to no avail? All I'm reading is "I'm not happy with how
> > > > things work", with nothing specific.
> > > > 
> > > 
> > > Patch series are getting old (even years) repeatedly pinged (5/6 times)
> > > but they continue to not getting any feedback/ack/comment.
> > > If you can't remember any... this just confirms the problem.
> > 
> > So I went through my mails (searched for mails containing 'ping'), in
> > the last months I found 24 series which needed a ping, among these, 3
> > needed several pings, and it stopped at 2 pings. Maybe I missed some.
> > 
> 
> As I said there are series that last years, not months and you
> should consider the multiple sending of them too.

IF multiple sendings are happening that often without a review, I would
say they are part of the problem, and that this should be avoided if
possible, and that they are making keeping track of patches/pending
series harder.
I understand this is wishful thinking as if a series has evolved, you
don't have much choice than resending it. Maybe that means pings should
be sent earlier (I would say 1 or 2 weeks without an answer is a good
rule of thum).

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170726/e6b934fb/attachment.sig>